Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Solve sync build issue #41532

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jun 27, 2024

Restructure the conditionalization to avoid breaking the regexp that Michal wrote to transform the tabs, per @gsmet's suggestion.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 28, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f1a0698.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Jun 28, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c1a53dc.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
✔️ JVM Tests - JDK 21 Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/grpc-descriptor-sets/grpc-descriptor-set-alternate-output-dir 

📦 integration-tests/grpc-descriptor-sets/grpc-descriptor-set-alternate-output-dir

io.quarkus.grpc.examples.hello.DescriptorSetExistsTest.descriptorSetExists line 16 - History - More details - Source on GitHub

java.lang.AssertionError: 

Expecting path:
  /home/runner/work/quarkus/quarkus/integration-tests/grpc-descriptor-sets/grpc-descriptor-set-alternate-output-dir/target/proto
to exist (symbolic links were followed).
	at io.quarkus.grpc.examples.hello.DescriptorSetExistsTest.descriptorSetExists(DescriptorSetExistsTest.java:16)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 4f09303 into quarkusio:3.8 Jun 28, 2024
5 checks passed
@gsmet
Copy link
Member

gsmet commented Jun 28, 2024

@rolfedh I merged it to unblock you but please follow the usual process of pushing to main and we will handle the backport.
We need the same PR for main for it to not break on next LTS. Thanks!

@sberyozkin
Copy link
Member

Thanks @rolfedh @gsmet

@rolfedh rolfedh mentioned this pull request Jun 28, 2024
@rolfedh
Copy link
Contributor Author

rolfedh commented Jun 28, 2024

@rolfedh I merged it to unblock you but please follow the usual process of pushing to main and we will handle the backport.
We need the same PR for main for it to not break on next LTS. Thanks!

Very appreciated, Guillaume. Will do.
Here's the same Pr for main: #41557

@rolfedh rolfedh changed the title Solve sync build issue [3.8] Solve sync build issue Jun 28, 2024
@gsmet gsmet added this to the 3.8.6 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants